Skip to content

test: Check that _convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator#1953

Merged
sjrl merged 10 commits intomainfrom
test-streaming-chunk-conversion
Aug 6, 2025
Merged

test: Check that _convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator#1953
sjrl merged 10 commits intomainfrom
test-streaming-chunk-conversion

Conversation

@sjrl
Copy link
Copy Markdown
Contributor

@sjrl sjrl commented Jun 16, 2025 •
edited
Loading

Related Issues

Proposed Changes:

  • Add unit test that each Mistral chunk is converted into the expected Haystack StreamingChunk
  • Update other tool integration tests to call two tools so the more complicated case is tested
  • Added a unit test that explicitly tests that the Mistral Chunks are properly converted into the final Haystack ChatMessage

How did you test it?

Notes for the reviewer

Checklist

@sjrl sjrl changed the title test: Check that OpenAIChatGenerator._convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator test: Check that _convert_chat_completion_chunk_to_streaming_chunk works for MistralChatGenerator Jun 17, 2025
@sjrl sjrl mentioned this pull request Jun 17, 2025
Merged
@github-actions github-actions Bot added the type:documentation Improvements or additions to documentation label Jun 17, 2025
@sjrl sjrl self-assigned this Jun 17, 2025
@sjrl
Copy link
Copy Markdown
Contributor Author

sjrl commented Jun 18, 2025

This is done, but putting on hold until this PR deepset-ai/haystack#9525 is merged and the next version of Haystack is released.

@sjrl sjrl mentioned this pull request Jun 30, 2025
Merged
@sjrl sjrl marked this pull request as ready for review July 1, 2025 11:26
@sjrl sjrl requested a review from a team as a code owner July 1, 2025 11:26
@sjrl sjrl requested review from vblagoje and removed request for a team July 1, 2025 11:26
vblagoje
vblagoje reviewed Aug 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vblagoje vblagoje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. LGTM

@sjrl sjrl enabled auto-merge (squash) August 6, 2025 08:07
@vblagoje vblagoje self-requested a review August 6, 2025 08:07
@sjrl sjrl merged commit 37dae5f into main Aug 6, 2025
11 checks passed
@sjrl sjrl deleted the test-streaming-chunk-conversion branch August 6, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vblagoje vblagoje vblagoje approved these changes

Assignees

@sjrl sjrl

Labels

integration:mistral type:documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sjrl @vblagoje